Skip to content

feat: persist best ChainLock to disk via MetadataStorage #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xdustinface wants to merge 1 commit into
base: v0.42-dev
Choose a base branch
from
Open

feat: persist best ChainLock to disk via MetadataStorage #419

xdustinface wants to merge 1 commit into from
+245 −24

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Feb 5, 2026

Add M: MetadataStorage generic to ChainLockManager so the best validated ChainLock can be saved to disk on every update and restored on initialization.

Based on:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026 •
edited
Loading

Warning

Rate limit exceeded

@xdustinface has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 27 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/chainlock-persistence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from refactor/cleaup-storage-usage to v0.42-dev February 9, 2026 22:57
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

@github-actions github-actions bot added the merge-conflict The PR conflicts with the target branch. label Feb 9, 2026
@xdustinface
feat: persist best ChainLock to disk via MetadataStorage
bab8812 
Add `M: MetadataStorage` generic to `ChainLockManager` so the best
validated ChainLock can be saved to disk on every update and restored
on initialization.
@xdustinface xdustinface force-pushed the feat/chainlock-persistence branch from 3875240 to bab8812 Compare February 9, 2026 23:14
@github-actions github-actions bot removed the merge-conflict The PR conflicts with the target branch. label Feb 9, 2026
@xdustinface xdustinface marked this pull request as ready for review February 10, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xdustinface